Add support for Maven artifact classifers #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am 👍 on this. My only question is to ask what your thoughts are on the usage of |
| version = coordinates.split(':')[3] | ||
| if Chef::Artifact.latest?(version) | ||
| artifact = NexusCli::Artifact.new(coordinates) | ||
| if Chef::Artifact.latest?(artifact.version) | ||
| REXML::Document.new(remote.get_artifact_info(coordinates)).elements["//version"].text | ||
| else | ||
| version |
There was a problem hiding this comment.
This should be artifact.version to handle cases where the version isn't 'latest'
|
+1 for this, it's why I initially created the pull request for maven classifiers in nexus_cli. |
KAllan357
referenced
this pull request
in aaronfeng/artifact-cookbook
Oct 30, 2013
the original code assumed whatever value after the extension is the version. This is not necessary true since the classifier can come between the version and extension.
|
Thank you! Merged in with #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces brittle splitting/joining with parsing of coordinates by
nexus_cli. Support for classifiers is mostly a side-effect.The addition of a method similar to
NexusCli::Artifact:file_namebased onproviders/deploy.rb:63-67would make the code here completely classifier ignorant.